-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-51524: Fix bug when calling trace.CoverageResults with valid infile #99629
Conversation
furkanonder
commented
Nov 20, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: trace.CoverageResult fails merging input file with non-empty callers #51524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor edit and addition of blurb. Does following seen sufficient?
Fix bug when calling trace.CoverageResults with valid infile.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy I have made the requested changes. Can you review it again? |
Thanks @furkanonder for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-99832 is a backport of this pull request to the 3.11 branch. |
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-99833 is a backport of this pull request to the 3.10 branch. |