gh-51524: Fix bug when calling trace.CoverageResults with valid infile #99629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
furkanonder
commented
Nov 20, 2022
•
furkanonder
commented
- Issue: trace.CoverageResult fails merging input file with non-empty callers #51524
furkanonder
changed the title
furkanonder
requested review from
brettcannon,
a team,
encukou,
ethanfurman,
gvanrossum,
Fidget-Spinner,
JelleZijlstra,
AlexWaygood,
terryjreedy,
ericvsmith,
rhettinger,
berkerpeksag,
gpshead,
erlend-aasland,
cjw296,
isidentical,
pablogsal,
lysnikolaou,
pganssle,
abalkin,
ericsnowcurrently,
ncoghlan,
warsaw and
ezio-melotti
as code owners
AlexWaygood
removed request for
brandtbucher,
markshannon,
methane,
1st1 and
asvetlov
terryjreedy
reviewed
Nov 20, 2022
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
@terryjreedy I have made the requested changes. Can you review it again? |
furkanonder
requested review from
terryjreedy
and removed request for
iritkatriel
gvanrossum
changed the title
terryjreedy
added
type-bug
|
Thanks @furkanonder for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-99832 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2022
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2022
… infile (pythonGH-99629) (cherry picked from commit 594de16) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-99833 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.